updating obsolete method for BigQuery#1482
updating obsolete method for BigQuery#1482take4mats wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
Thank you for providing nice tutorials. This is quickest proposal to make it work with latest client library. - Line 339: `table.import(...)` doesn't work and need to use `table.load(...)` instead. - Line 341: `job` doesn't have `promise()`
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
googlebot
added
the
cla: no
|
@take4mats thanks for the fix! Could you sign the CLA? Thank you |
ace-n
left a comment
ace-n
left a comment
There was a problem hiding this comment.
N.B: We're planning to land a pretty big lint change soon - it might be easier to re-create this PR on top of it.
|
@fhinkel sorry for belated reaction... @googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
googlebot
added
cla: yes
|
@take4mats so sorry, as @ace-n mentioned, we landed a large change and have merge conflicts now. Do you want to resolve them? Thanks |
|
@fhinkel No, you can discard mine and prioritize the big change. Thank you. |
Replica of #1482 with newer changes to master
4 participants
Thank you for providing nice tutorials.
This is quickest proposal to make it work with latest client library.
table.import(...)doesn't work and need to usetable.load(...)instead.jobdoesn't havepromise()